Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug reg long coordinates #90

Merged
merged 1 commit into from
Sep 24, 2021
Merged

fix bug reg long coordinates #90

merged 1 commit into from
Sep 24, 2021

Conversation

rasbt
Copy link
Member

@rasbt rasbt commented Sep 24, 2021

Description

Fixes a bug where coordinates with more than 4 digits before the decimal point caused a column shift when saving a PDB file.

Related issues or pull requests

Fixes #89

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./biopandas/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under biopandas/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./biopandas -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./biopandas/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./biopandas

@rasbt rasbt merged commit 980d4f7 into main Sep 24, 2021
nozomu-y pushed a commit to nozomu-y/biopandas that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PandasPdb.to_pdb() will add one more blank for coordinate larger than 1000
1 participant